[eas-cli] add a credentials:configure-build subcommand that prepares a project for EAS Build without executing the build from the CLI
#2282
Conversation
|
Size Change: -1.75 kB (0%) Total Size: 51.4 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2282 +/- ##
==========================================
- Coverage 53.94% 53.78% -0.15%
==========================================
Files 520 525 +5
Lines 18993 19115 +122
Branches 4013 4037 +24
==========================================
+ Hits 10243 10279 +36
- Misses 8035 8114 +79
- Partials 715 722 +7 ☔ View full report in Codecov by Sentry. |
FiberJW
force-pushed
the
fiberjw/eng-11573-create-an-eas-cli-command-that-does-the-credentials-setup
branch
from
3f1b4b2 to
94b217c
Compare
FiberJW
changed the title
credentials:configure-build subcommand that prepares a project for EAS Build without executing the build from the CLI
packages/eas-cli/src/credentials/manager/SetUpAndroidBuildCredentials.ts
Show resolved
Hide resolved
FiberJW
force-pushed
the
fiberjw/eng-11573-create-an-eas-cli-command-that-does-the-credentials-setup
branch
from
f1984db to
ebf0b34
Compare
|
✅ Thank you for adding the changelog entry! |
FiberJW
requested review from
khamilowicz,
sjchmiela and
szdziedzic
as code owners
szdziedzic
left a comment
szdziedzic
left a comment
There was a problem hiding this comment.
it's awesome, thanks! it looks good to me! I gave it a try locally and everything works well.
One follow-up thing we can do is to add credentials:configure-submit. It would be useful to also set up people using GH builds with --auto-submit this way, so we make sure that they have an ASC API key set on our servers. Or even make it a part of this command? What do you think about it?
|
Setting up auto-submit credentials is a good idea! I think making that a separate command is a good way to start and allow people to run what they want individually, but we can create a super credentials command that sets up everything for build, submit, notifications, and anything else later |
FiberJW
deleted the
fiberjw/eng-11573-create-an-eas-cli-command-that-does-the-credentials-setup
branch
Why
To help a developer get configured for GitHub builds, it would be nice to let them use an EAS CLI command locally that sets up credentials for a build without actually executing it. In theory it would be awesome to be able to do this work from the browser/server, but as we know, some constraints prevent us from that.
How
I added a new command that largely inherits most of its behavior from
ManageIos/ManageAndroid, but goes right to theSetUpBuildCredentialsstep for each platform, skipping printing out existing credentials and the 4+ step prompt flow that takes you to this action.Test Plan
With
neasas an alias pointed to my local build of EAS CLI,neas credentials:configure-buildshould prompt you for both parameters and execute the build credentials setup for the selected platform.neas credentials:configure-build --platform <android/ios>should prompt you for a build profile listed inside your eas.json and execute the build credentials setup for the selected platform.neas credentials:configure-build --platform <android/ios> --profile PROFILE_NAMEshould immediately execute the build credentials setup for the selected platform.